Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nixpkgs fails to build on unstable #50

Closed
JCapucho opened this issue Jan 25, 2022 · 4 comments · Fixed by NixOS/nixpkgs#156868
Closed

Nixpkgs fails to build on unstable #50

JCapucho opened this issue Jan 25, 2022 · 4 comments · Fixed by NixOS/nixpkgs#156868

Comments

@JCapucho
Copy link

Hi, I'm using colmena with a flake to build a node that uses the nixos-unstable branch of nixpkgs (commit is NixOS/nixpkgs@689b76b), but it's failing to build.

In the start of the log I see a warning with

capucho-nixos | trace: warning: The following Nixpkgs configuration keys set in meta.nixpkgs will be ignored: path

Which leads me to believe that the issue might be caused by ignoring the path attribute introduced in NixOS/nixpkgs#153594

Here's the log of running colmena build --show-trace --verbose
log.txt
zhaofengli added a commit that referenced this issue Jan 25, 2022
@zhaofengli
eval.nix: Don't override modulesPath
e58dde1 
`eval-config.nix` will set the canonical path for us that will then be used
to strip the module path prefixes in `nixos/modules/misc/documentation.nix` [1].
This should fix split docs build problems described in #50.

[1] https://github.com/NixOS/nixpkgs/blob/1511e72b75b49cdeeee68def0c203f997d01bafa/nixos/modules/misc/documentation.nix#L79
@zhaofengli
Copy link
Owner

From the logs, it seems like it's a problem with the split docs build:

capucho-nixos | Cacheable portion of option doc build failed.
capucho-nixos | Usually this means that an option attribute that ends up in documentation (eg `default` or `description`) depends on the restricted module arguments `config` or `pkgs`.

Can you confirm whether e58dde1 fixes the issue?

zhaofengli added a commit that referenced this issue Jan 25, 2022
@zhaofengli
integration-tests: Enable documentation build
6bff965 
It makes sense to keep the tests as close to real life (docs enabled)
as possible.

Ref: #50
zhaofengli added a commit that referenced this issue Jan 26, 2022
@zhaofengli
eval.nix: Don't override modulesPath
6877bb0 
`eval-config.nix` will set the canonical path for us that will then be used
to strip the module path prefixes in `nixos/modules/misc/documentation.nix` [1].
This should fix split docs build problems described in #50.

[1] https://github.com/NixOS/nixpkgs/blob/1511e72b75b49cdeeee68def0c203f997d01bafa/nixos/modules/misc/documentation.nix#L79
@JCapucho
Copy link
Author

Just tested on the latest commit, it's all working now, thanks for the quick fix

@zhaofengli
Copy link
Owner

Let's keep this open until I also backport the fix to 0.2.

@zhaofengli zhaofengli reopened this Jan 26, 2022
@zhaofengli zhaofengli pinned this issue Jan 26, 2022
zhaofengli added a commit that referenced this issue Jan 26, 2022
@zhaofengli
Release 0.2.1
52cc4fb 
This release fixes the issue (#50) where sandboxed documentation
builds [1] fail when using the unstable Nixpkgs channel.

[1] NixOS/nixpkgs#149532
@zhaofengli zhaofengli mentioned this issue Jan 26, 2022
Merged
13 tasks
@zhaofengli
Copy link
Owner

Closing since 0.2.1 has landed in both nixos-unstable and nixos-21.11. Thanks for the report!

@zhaofengli zhaofengli unpinned this issue Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

colmena: 0.2.0 -> 0.2.1 zhaofengli/nixpkgs
2 participants
@zhaofengli @JCapucho