I26 wasm add async #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- faster if I just test this crate alone.
- tried to implement an umbrella trait for them, but for some reason, that didn't work. - it might be worth investigating why tho
- however, when constructing an `EthereumType` from an integer, a reference to an integer is required which might be a bit inconvenient.
added 20 commits
May 14, 2021 15:13
However - client is cloned every time a call is made (not sure how fast this is)
- Untrack `www` folder - show decimal equivalent of some hex numbers
`Parameter` stores data in a `H256` type, but it wasn't converted to an `Address`, when displaying it. This means, that instead of 20 bytes, 32 bytes were displayed.
added 2 commits
May 25, 2021 14:37
PumpkinSeed
approved these changes
May 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempts to resolve #36, resolve #26.
Description
There are quite some proposed changes in this pull request and they originate from the following issues.
It was required to compile
Ethanein such way that it is supported bywasmapplications. However, we bumped into weird errors similar to this and this. Thus we decided to get rid of as many dependencies as possible in order to find the culprit which turned out to be theureqpackage.Therefore, the
Httpclient was modified to usereqwest::blocking::Clientto handle blocking http requests without futures and multiple threads. However, this opened a new issue, namelywasmdoesn't support blocking requests. Thus, a blocking and a non-blocking (async)Httpclient was added toEthane.Currently the crate has a
blockingand anon-blockingfeature flag that compiles only the more lightweight sync or the more complex asyncHttpclient respectively. Then, there is a blocking and a non-blockingConnectionthrough which theRPCrequests are sent and processed. Furthermore, the contractCallerwas also split into a blocking and non-blocking object to handleethcontract calls.Ethane types
In this great "purge", the
ethereum-typecrate was also dismissed from the dependencies andEthane's own implementation was added. You can find theAddress,Bloom,U256, etc types compiled locally, with slightly different API methods.WASM
ethane-wasmcontains a very basicwasm-compatible implementation of anRPCinterface. It is an exploratory implementation only in order to test compatibility issues and tweaks to call ethane viawasm.