-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DecayLanguage compatibility #63
Conversation
Great to see this PR! Can you explicitly link to DecayLanguage's task scikit-hep/decaylanguage#86 in the description header since this is addressing it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice and thanks a lot! I agree with Eduardos comments, additional thoughts
- name, what about "fromdec" or "fromdecay"?
- the docstyle in phasespace is the google one, not the numpy (see other docs)
For the docs, I would suggest to create a jupyter notebook with a good example, this can then be converted into a static html page (such as done in zfit for example). I suggest to create a notebook (in docs is fine) that explains and introduces the feature |
Co-authored-by: Jonas Eschle <[email protected]>
for more information, see https://pre-commit.ci
…space into decay2phasespace
for more information, see https://pre-commit.ci
Co-authored-by: Jonas Eschle <[email protected]>
Co-authored-by: Jonas Eschle <[email protected]>
Also made some minor clarifications to the docstrings.
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is ready for a first version 👍.
Yep, I agree! Just figuring out how to successfully also run the notebook, there is some weird issue with graphviz |
Ah, if it is for conda then you need python-graphviz, see https://github.com/conda-forge/decaylanguage-feedstock/blob/master/recipe/meta.yaml#L26. |
So I didn't figure out the CI failures yet fully, but it is not related to the PR directly but rather that some software packages play weird together. I am still checking it |
Sorry to hear about the pain. For Python 3.6 I had a speedy look just now and see |
Yeah, Python 3.6 makes sense, thanks! That is a more trivial one (also, we should soon remove support for it I think), the others are just weird... and I can't reproduce it locally. Still trying, and maybe there is also gonna be a magical fix soon somewhere :D |
This is really annoying. Looking online for the error I got to tensorflow/tensorflow#51592. Does it help you? |
Yeaish, that's what I suspect, so I hope it may gets fixed. But then I cannot reproduce that locally, which is rather weird. Version mismatches should not really happen, or if, then it's maybe just because a new version was released newly and now packages react. I'll give it a week or so more, and if that doesn't resolve it (TF2.7 was just resently released), I'll dig more into it. Thanks though for the help! |
Since we dropped Python 3.6, this is now surely a go! Many thanks @simonthor and @eduardo-rodrigues for getting this in! |
Thank you both as well for the guidance throughout this process! |
Solves scikit-hep/decaylanguage#86. See this issue for further information.
The code works and all tests pass on Linux.
Tasks left to do:
fulldecay
part (e.g., make it possible to runpip install phasespace[fulldecay]
)