Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README - fix charge in GenParticle example #61

Merged
merged 1 commit into from
Sep 1, 2021

Conversation

eduardo-rodrigues
Copy link
Contributor

@eduardo-rodrigues eduardo-rodrigues commented Aug 26, 2021

There was a trivial typo and the README example violated charge conservation ;-). While at it I updated a couple of masses to the PDG 2021 values.

There may be other places where the K*0 -> K+ pi- example is used ... to be checked.

There was a trivial typo that violated charge conservation ;-). While at it I upated a couple of masses to the PDG 2021 values.
@eduardo-rodrigues
Copy link
Contributor Author

@jonas-eschle, can this trivial fix get merged? Advance thanks.

@jonas-eschle
Copy link
Contributor

Sure! I actually wanted to directly replace it with particle, that make more sense, I guess you agree?
But let's merge it and we can make a new PR for that anyways

Thanks a lot for the PR!

@jonas-eschle jonas-eschle merged commit 5811e71 into zfit:master Sep 1, 2021
@eduardo-rodrigues
Copy link
Contributor Author

Sure! I actually wanted to directly replace it with particle, that make more sense, I guess you agree?
But let's merge it and we can make a new PR for that anyways

Thanks a lot for the PR!

A looong time ago we talked about that and you said that a simple example was a good thing, not to "convolve" with functionality of a different package. I think you had a point - the basic example should be a "bare example". This being said, another example together with the ecosystem is worth having as part of a little notebook or the Scikit-HEP tutorials, and we can work on that aside this MR here. Thanks for the swift reminder :-).

@eduardo-rodrigues eduardo-rodrigues deleted the patch-1 branch September 1, 2021 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants