fix: focus background not applied on list #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ry status Replace the implementation of the List with the ListV2 and move the management of the background in a single point, the CustomListItem. Refactor the types in order to remove some any and some ts-ignore refs: IRIS-3740
refs: IRIS-3740
beawar
requested review from
nubsthead,
giuliano176,
dhavaldodiya,
Gammax92 and
gnekoz
as code owners
|
Please check with extra attention the types and see if there is some typing which is not correct. I've tried to refactor considering the inferred types but something might be not right. |
giuliano176
previously approved these changes
Feb 1, 2023
- @zextras/carbonio-ui-sdk 1.5.0 - @zextras/carbonio-design-system 1.1.0 - @zextras/carbonio-shell-ui 1.1.0 refs: IRIS-3740
giuliano176
previously approved these changes
Feb 7, 2023
nubsthead
previously approved these changes
Feb 13, 2023
giuliano176
previously approved these changes
Feb 15, 2023
Gammax92
previously approved these changes
Feb 15, 2023
nubsthead
previously approved these changes
Feb 15, 2023
giuliano176
dismissed stale reviews from nubsthead, Gammax92, and themself
via
32f9b82
giuliano176
approved these changes
Feb 15, 2023
dhavaldodiya
approved these changes
Feb 16, 2023
giuliano176
deleted the
IRIS-3740-focus-background-not-applied-on-list
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace List component with the Custom ListV2.
Manage items independently from the List itself.
Clean up the management of the background for the items, using only the CustmListItem, the HoverContainer and the HoverBarContainer to set the background.
Refactor some types in order to remove some any, some ts-ignore and some cast.
refs: IRIS-3470