New props and types export #98
Conversation
gnekoz
commented
Jul 19, 2022
gnekoz
commented
- Modified the Link component adding the href prop
- Exported the LabelFactoryProps type related to the Select component
Set the dependency to only windowObj instead of windowObj.document.activeElement in order to avoid the hook to re-run each time the activeElement change. This change was causing for modals a reset of the focused element to the modal itself, making the input inside losing focus while typing. refs: CDS-54
…-devel fix: avoid contents inside modal to lose focus on change of active node
gnekoz
requested review from
zovomat,
nubsthead,
giuliano176,
geeky-abhishek,
dhavaldodiya,
CataldoMazzilli,
beawar,
lisaparma and
CerDennis
as code owners
|
Regarding the Link component typing, I'm not convinced by this solution. I think we could simplify the definition of this component removing the props already defined in Text, and defining it as an extension of the AnchorElement to accept also other attributes of the anchor tag. It could become something like type LinkProps = {
/** Whether the link should be underlined */
underlined?: boolean;
} & React.AnchorHTMLAttributes<HTMLAnchorElement> &
TextProps;Particularly, I don't like this line where you need to declare href on the styled component: That section of attrs should be used only for props which are declared dynamically by some condition or for props with a fixed value (like the forwardedAs, which should be always "a" for this component) I tried to make these changes to see if the href is accepted by typescript when using a Link, see this patch |
|
I agree on the new definition of LinkProps and I confirm it's working without raising TS errors. I just pushed the patched version |
