Fix TypeScript config in typechecking mode #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/zdx/useisinviewport/h94cgmc2y |
zeusdeux
approved these changes
Mar 16, 2020
|
I think you might need to push again. CircleCI seems to have died :\ |
|
Oh and as for the |
|
Thanks for this @nwalters512! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in microsoft/TypeScript#36917, recent versions of TypeScript don't allow the
--noEmitflag to be set alongside"composite": true. This PR updates thetypecheckscript to pass--composite falsetotscto fix this.Side note: what do you think about committing a
package-lock.jsonfile to the repo? That would help ensure that everyone is working with the expected versions of dev dependencies.