Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: slither v2 action and slither issues #286

Merged
merged 65 commits into from
Aug 6, 2024
Merged

fix: slither v2 action and slither issues #286

Show file tree
Hide file tree
Changes from 64 commits
Commits
Show all changes
65 commits
Select commit Hold shift + click to select a range
5b5cc4b
access control for erc20 custody new
skosito Jul 23, 2024
f1cf789
cleanup erc20 custody new events and errors
skosito Jul 23, 2024
8b9669e
access control for gateway evm
skosito Jul 23, 2024
1851b89
move connector events to interface
skosito Jul 23, 2024
ba0f25f
add tss address to connector and fix uniswap integration test
skosito Jul 23, 2024
3f4990c
tests for tss sender in connector
skosito Jul 23, 2024
a686f66
remove access control todos from zevm contracts
skosito Jul 23, 2024
58160e8
generate
skosito Jul 23, 2024
0f8ab79
missing access control
skosito Jul 23, 2024
72e1200
init v2 folder
skosito Jul 24, 2024
8fafcbd
use npm
skosito Jul 24, 2024
99aaebb
moving files
skosito Jul 24, 2024
8e5b78f
moving files
skosito Jul 24, 2024
2964b06
move upgrade test
skosito Jul 24, 2024
3eac2ca
connector tests
skosito Jul 24, 2024
c0dbd8c
wip
skosito Jul 24, 2024
394e7c5
forge fmt
skosito Jul 24, 2024
09be45c
move echidna
skosito Jul 24, 2024
6672b9e
using submodule for forge-std
skosito Jul 24, 2024
2ea0a59
forge install: openzeppelin-contracts-upgradeable
skosito Jul 24, 2024
a8ec2b1
use submodules
skosito Jul 24, 2024
3a57e9d
move existing to v1 folder
skosito Jul 26, 2024
a3bf3f2
Merge branch 'main' into v1-v2-split
skosito Jul 29, 2024
731aa1e
yarn generate for v1
skosito Jul 29, 2024
3d6a870
cleanup
skosito Jul 29, 2024
3d736e5
conflicts
skosito Jul 29, 2024
0ec2a72
try to fix build action
skosito Jul 29, 2024
b334516
fixing v1 actions
skosito Jul 29, 2024
307a455
fix test v1
skosito Jul 29, 2024
d00c832
add paths to v1 actions
skosito Jul 29, 2024
b8db384
forge fmt
skosito Jul 29, 2024
56ef158
add test v2 and cleanup v1 actions
skosito Jul 29, 2024
9a7dd16
fix
skosito Jul 29, 2024
28af3e6
fix
skosito Jul 29, 2024
dd4cbeb
remove build v1 action and rename test actions steps
skosito Jul 29, 2024
2a01ed1
feat: port localnet to v2 (#269)
skosito Jul 29, 2024
4c013a2
readme and test fixes
skosito Jul 29, 2024
f401c98
lint v2
skosito Jul 29, 2024
8af5d05
enable coverage and slither on v2
skosito Jul 29, 2024
545201b
remove broadcast folder
skosito Jul 29, 2024
5231707
fix PR comments
skosito Jul 30, 2024
f4c1c7d
merge main
skosito Jul 30, 2024
640e67d
refactor: v2 bindings (#270)
skosito Jul 30, 2024
6835971
refactor: remove new suffix from v2 contracts (#272)
skosito Jul 31, 2024
5f2ea3c
feat: add missing access control (#277)
skosito Aug 1, 2024
ad2f4d9
modify zrc20
skosito Aug 1, 2024
a7897cd
generate
skosito Aug 1, 2024
48bf0de
add unit tests for zrc20
skosito Aug 1, 2024
b5a5576
generate
skosito Aug 1, 2024
a06e946
generate
skosito Aug 1, 2024
5a3892e
PR comment
skosito Aug 2, 2024
38081fb
Merge branch 'main' into zrc-20-fixes
skosito Aug 2, 2024
ca92f50
generate
skosito Aug 2, 2024
364c3ef
improve test a bit
skosito Aug 5, 2024
74e7334
try to fix slither not running in v2 folder
skosito Aug 5, 2024
4740c65
add slither config
skosito Aug 5, 2024
7c6080a
test
skosito Aug 5, 2024
c1e759d
fix solc version
skosito Aug 5, 2024
0393398
fix some slither issues
skosito Aug 5, 2024
bd903e5
fix more issues
skosito Aug 5, 2024
7897772
fail on medium findings
skosito Aug 5, 2024
e3a8113
generate
skosito Aug 5, 2024
9d902b9
generate
skosito Aug 5, 2024
915abde
merge main
skosito Aug 5, 2024
5bee684
Merge branch 'main' into fix-slither-not-running
skosito Aug 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .github/workflows/slither_v2.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,10 @@ jobs:
with:
sarif: results.sarif
node-version: "21.1.0"
fail-on: none
slither-config: "v2/slither.config.json"
solc-version: "0.8.26"
skosito marked this conversation as resolved.
Show resolved Hide resolved
fail-on: medium
target: "v2/"

- name: Upload SARIF file
uses: github/codeql-action/upload-sarif@v3
Expand Down
39 changes: 4 additions & 35 deletions v2/pkg/erc20custody.sol/erc20custody.go
View file
Open in desktop

Large diffs are not rendered by default.

35 changes: 2 additions & 33 deletions v2/pkg/erc20custodyechidnatest.sol/erc20custodyechidnatest.go
View file
Open in desktop

Large diffs are not rendered by default.

58 changes: 29 additions & 29 deletions v2/pkg/gatewayevm.sol/gatewayevm.go
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion v2/pkg/gatewayevm.t.sol/gatewayevminboundtest.go
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion v2/pkg/gatewayevm.t.sol/gatewayevmtest.go
View file
Open in desktop

Large diffs are not rendered by default.

58 changes: 29 additions & 29 deletions v2/pkg/gatewayevmechidnatest.sol/gatewayevmechidnatest.go
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion v2/pkg/gatewayevmupgrade.t.sol/gatewayevmuupsupgradetest.go
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion v2/pkg/gatewayevmupgradetest.sol/gatewayevmupgradetest.go
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions v2/pkg/gatewayevmzevm.t.sol/gatewayevmzevmtest.go
View file
Open in desktop

Large diffs are not rendered by default.

22 changes: 11 additions & 11 deletions v2/pkg/gatewayzevm.sol/gatewayzevm.go
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions v2/pkg/gatewayzevm.t.sol/gatewayzevminboundtest.go
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions v2/pkg/gatewayzevm.t.sol/gatewayzevmoutboundtest.go
View file
Open in desktop

Large diffs are not rendered by default.

128 changes: 127 additions & 1 deletion v2/pkg/igatewayevm.sol/igatewayevm.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading