-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove new suffix from v2 contracts #272
Conversation
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Base branches to auto review (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v1-v2-split #272 +/- ##
===============================================
+ Coverage 51.35% 58.41% +7.06%
===============================================
Files 17 16 -1
Lines 407 404 -3
Branches 28 28
===============================================
+ Hits 209 236 +27
+ Misses 195 165 -30
Partials 3 3 ☔ View full report in Codecov by Sentry. |
As it just concerns renaming on the split branch |
closes: #250
uncommented zeta connector non native tests
added new issue for some missing unit tests: Add tests for v2 non-protocol contracts #271