Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: publish to npm fix #57

Merged
merged 1 commit into from
Oct 21, 2024
Merged

ci: publish to npm fix #57

merged 1 commit into from
Oct 21, 2024

Conversation

fadeev
Copy link
Member

@fadeev fadeev commented Oct 18, 2024

Just using the same logic as in localnet, which seems to be working.

@fadeev fadeev linked an issue Oct 18, 2024 that may be closed by this pull request
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 8.17%. Comparing base (362a59f) to head (897204f).

Additional details and impacted files
@@          Coverage Diff          @@
##            main     #57   +/-   ##
=====================================
  Coverage   8.17%   8.17%           
=====================================
  Files          1       1           
  Lines        318     318           
=====================================
  Hits          26      26           
  Misses       292     292           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@fbac fbac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but not sure if this should also be reviewed by @zeta-chain/devops

@fadeev fadeev merged commit 6367073 into main Oct 21, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix npm publishing
4 participants