feat: observer rewards #855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kingpinXD
commented
Aug 9, 2023
| } | ||
| rewardPerUnit := sdkmath.ZeroInt() | ||
| if totalRewardsUnits > 0 && amount.IsPositive() { | ||
| rewardPerUnit = amount.Quo(sdk.NewInt(totalRewardsUnits)) |
There was a problem hiding this comment.
Ballots can be cleared after this distribution if needed, decided not to do this in this PR . Can be added in later
lumtis
requested changes
Aug 9, 2023
kevinssgh
reviewed
Aug 9, 2023
We are not tracking the performance. Is there a reason to do that? The ballots are not deleted, so we could write an off-chain solution to create that if needed. Lets discuss this over a GitHub issue if needed |
|
Ok we can do that separately. |
brewmaster012
approved these changes
Aug 11, 2023
ws4charlie
reviewed
Aug 11, 2023
| @@ -15,7 +15,8 @@ message GenesisState { | |||
| repeated Ballot ballots = 1; | |||
| repeated ObserverMapper observers = 2; | |||
| repeated NodeAccount nodeAccountList = 3; | |||
There was a problem hiding this comment.
put snake case on this field as well?
ws4charlie
approved these changes
Aug 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add functions to
testutil/networkfor addingcrosschainandobservergenesis state, which tests can use in all modules. Refactor existing tests to use these functions instead of local counterparts in the module itselfAdd begin block function in
emissionsmodule to calculate and allocate rewardsMove
Block Reward componentsto its file underemissons/keeperAdd ballot creation height to
ballots.Add
BallotMaturityHeightparam .Add unit tests for
BuildRewardsDistributionandDistributeObserverRewardsThis PR does not add a migration script to modify existing ballots on the testnet , or distribute any of the older rewards
Closes: #839
Type of change