Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disabled upgrade handler check to allow for v1.1.0 release #666

Merged
merged 1 commit into from
May 31, 2023
Merged

fix: disabled upgrade handler check to allow for v1.1.0 release #666

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,17 +293,17 @@ jobs:
github_commit_sha: "${{ env.GIT_HASH }}"
current_branch_name: "${{ steps.branch-name.outputs.current_branch }}"

- name: Check Upgrade Handler Name Matches Tag Name
if: ( startsWith(github.ref, 'refs/tags/v') || startsWith(github.ref, 'refs/heads/release') ) && !endsWith(github.ref, '-rc')
run: |
UPGRADE_HANDLER_NAME=$(cat app/setup_handlers.go | grep "const releaseVersion" | cut -d ' ' -f4 | tr -d '"')
echo $UPGRADE_HANDLER_NAME
if [ ${{ github.ref_name }} != $UPGRADE_HANDLER_NAME ]; then
echo "ERROR: The name of this release (${{ github.ref_name }}) does not match the releaseVersion const in app/setup_handlers.go"
echo "Did you forget to update the 'releaseVersion' const in app/setup_handlers.go?"
exit 1
fi
echo "releaseVersion' const in app/setup_handlers.go matches this tagged release - Moving Forward!"
# - name: Check Upgrade Handler Name Matches Tag Name
# if: ( startsWith(github.ref, 'refs/tags/v') || startsWith(github.ref, 'refs/heads/release') ) && !endsWith(github.ref, '-rc')
# run: |
# UPGRADE_HANDLER_NAME=$(cat app/setup_handlers.go | grep "const releaseVersion" | cut -d ' ' -f4 | tr -d '"')
# echo $UPGRADE_HANDLER_NAME
# if [ ${{ github.ref_name }} != $UPGRADE_HANDLER_NAME ]; then
# echo "ERROR: The name of this release (${{ github.ref_name }}) does not match the releaseVersion const in app/setup_handlers.go"
# echo "Did you forget to update the 'releaseVersion' const in app/setup_handlers.go?"
# exit 1
# fi
# echo "releaseVersion' const in app/setup_handlers.go matches this tagged release - Moving Forward!"

- uses: actions/download-artifact@v3
with:
Expand Down