Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: demo e2e consensus failure #3129

Closed
wants to merge 1 commit into from

Conversation

gartnera
Copy link
Member

@gartnera gartnera commented Nov 7, 2024

This PR has a consensus breaking change to a precompiled contract.

zetacored will print consensus failure logs and blocks will not be produced:

7:44PM INF received complete proposal block hash=183BE96C3F20FB8FA3476492D1B7FE4DBB6974D936524741D5DF30D49FA56740 height=77 module=consensus server=node
7:44PM ERR prevote step: consensus deems this block invalid; prevoting nil err="wrong Block.Header.LastResultsHash.  Expected 7AD79ED7B61E2D45F42847BF9F5D138FE7EBF82057F2BC8D5EB43FCAA067EDCD, got 79AD3CF784C1DF78A8830139B68F815422FF03CFFF3C8A320291757A236D6DA3" height=77 module=consensus round=2 server=node
7:44PM INF Timed out dur=2000 height=77 module=consensus round=2 server=node step=RoundStepPrevoteWait
7:44PM INF Timed out dur=2000 height=77 module=consensus round=2 server=node step=RoundStepPrecommitWait
7:44PM INF resetting proposal info height=77 module=consensus proposer=F2F6B1C8C25DD9EC0DB1CF5A76B8D414AB99DE16 round=3 server=node
7:44PM INF received proposal module=consensus proposal="Proposal{77/3 (93510FC359ABE0FE716B0E8A004DE2BFD2EA88FDA780F1F06610F17BA02F4E7B:1:C2720008A40F, -1) E542E24DDA34 @ 2024-11-07T19:44:06.457676841Z}" proposer=F2F6B1C8C25DD9EC0DB1CF5A76B8D414AB99DE16 server=node
7:44PM INF received complete proposal block hash=93510FC359ABE0FE716B0E8A004DE2BFD2EA88FDA780F1F06610F17BA02F4E7B height=77 module=consensus server=node
7:44PM INF Timed out dur=2500 height=77 module=consensus round=3 server=node step=RoundStepPrevoteWait
7:44PM INF Timed out dur=2500 height=77 module=consensus round=3 server=node step=RoundStepPrecommitWait
7:44PM INF resetting proposal info height=77 module=consensus proposer=07BFC16195ADB516D4B086397CC678E83A7F05CE round=4 server=node
7:44PM INF received proposal module=consensus proposal="Proposal{77/4 (EC3F90BAF2A1AE54A8DC7710422D012910242E55AB64038D65A38C96A4ABF427:1:053D0C753F49, -1) 8B5683B8858E @ 2024-11-07T19:44:11.85042429Z}" proposer=07BFC16195ADB516D4B086397CC678E83A7F05CE server=node
7:44PM INF received complete proposal block hash=EC3F90BAF2A1AE54A8DC7710422D012910242E55AB64038D65A38C96A4ABF427 height=77 module=consensus server=node
7:44PM ERR prevote step: consensus deems this block invalid; prevoting nil err="wrong Block.Header.LastResultsHash.  Expected 7AD79ED7B61E2D45F42847BF9F5D138FE7EBF82057F2BC8D5EB43FCAA067EDCD, got 79AD3CF784C1DF78A8830139B68F815422FF03CFFF3C8A320291757A236D6DA3" height=77 module=consensus round=4 server=node
7:44PM INF Timed out dur=3000 height=77 module=consensus round=4 server=node step=RoundStepPrevoteWait

e2e will fail fast becuase blocks are not being produced:

precompile | ⏳running - test stateful precompiled contracts distribute
erc20      | ⏳ depositing ERC20 into ZEVM
bitcoin    | ⏳ depositing ERC20 into ZEVM
ether      | ⏳running - withdraw Ether from ZEVM
zeta       | ⏳ depositing Ethers into ZEVM
zevm_mp    | ⏳ depositing Ethers into ZEVM
zeta       | ⏳running - withdraw ZETA from ZEVM to Ethereum
zevm_mp    | ⏳running - zevm -> evm message passing contract call
bitcoin    | ⚙️ setting up Bitcoin account
erc20      | ⏳running - withdraw ERC20 from ZEVM
bitcoin    | ✅ Bitcoin account setup in 149.883914ms
bitcoin    | ⏳ depositing BTC into ZEVM
❌ block monitor: timed out waiting for new block (last block 76)
e2e failed

https://github.com/zeta-chain/node/actions/runs/11730180358/job/32677577335

@gartnera gartnera added no-changelog Skip changelog CI check CONSENSUS_TESTS Run make start-e2e-consensus-tests labels Nov 7, 2024
Copy link
Contributor

coderabbitai bot commented Nov 7, 2024

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added ci Changes to CI pipeline or github actions breaking:cli labels Nov 7, 2024
@gartnera gartnera changed the base branch from develop to e2e-consensus-test November 7, 2024 19:45
@github-actions github-actions bot removed ci Changes to CI pipeline or github actions breaking:cli labels Nov 7, 2024
@gartnera gartnera mentioned this pull request Nov 7, 2024
1 task
@gartnera gartnera closed this Nov 7, 2024
Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.25%. Comparing base (be4ad2a) to head (8ecb813).

Additional details and impacted files

Impacted file tree graph

@@                  Coverage Diff                   @@
##           e2e-consensus-test    #3129      +/-   ##
======================================================
- Coverage               63.29%   63.25%   -0.04%     
======================================================
  Files                     422      422              
  Lines                   29959    29953       -6     
======================================================
- Hits                    18962    18948      -14     
- Misses                  10157    10168      +11     
+ Partials                  840      837       -3     
Files with missing lines Coverage Δ
precompiles/staking/method_distribute.go 50.84% <ø> (+4.69%) ⬆️

... and 1 file with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CONSENSUS_TESTS Run make start-e2e-consensus-tests no-changelog Skip changelog CI check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant