-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: initialize cctx gateway interface #2291
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2291 +/- ##
===========================================
+ Coverage 69.26% 69.27% +0.01%
===========================================
Files 274 276 +2
Lines 16537 16563 +26
===========================================
+ Hits 11454 11474 +20
- Misses 4599 4604 +5
- Partials 484 485 +1
|
@lumtis just a draft PR for now to see if it's on right track, what do you think? most of the logic is copied and will be refined further with adding |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the direction is good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just changing review, I inadvertently approved on the last one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm , minor comments have a look before merging
Description
Adds new CCTXGateway interface and first part of implementation for observers and zevm. Check issue and docs for more details.
Closes: #2276
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.
Checklist: