Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add ChainInfo singleton state variable in authority #2275

Merged
merged 10 commits into from
May 29, 2024
Merged

feat: add ChainInfo singleton state variable in authority #2275

merged 10 commits into from
May 29, 2024

Conversation

lumtis
Copy link
Member

@lumtis lumtis commented May 28, 2024

Description

Initialize a new ChainInfo state variable in the authority store to allow dynamically adding new chain info without upgrade

Closes: #2270

@lumtis lumtis changed the title Feat/dynamic chain info feat: add ChainInfo singleton state variable in authority May 28, 2024
@codecov Codecov
Copy link

codecov bot commented May 28, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.94%. Comparing base (89ca461) to head (413a66f).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2275      +/-   ##
===========================================
+ Coverage    68.86%   68.94%   +0.08%     
===========================================
  Files          263      265       +2     
  Lines        16302    16344      +42     
===========================================
+ Hits         11226    11268      +42     
  Misses        4594     4594              
  Partials       482      482
Files Coverage Δ
pkg/chains/chain.go 96.58% <100.00%> (+0.46%) ⬆️
x/authority/genesis.go 100.00% <100.00%> (ø)
x/authority/keeper/chain_info.go 100.00% <100.00%> (ø)
x/authority/types/chain_info.go 100.00% <100.00%> (ø)
x/authority/types/genesis.go 100.00% <100.00%> (ø)

@lumtis
Copy link
Member Author

lumtis commented May 28, 2024

E2E tests fail in the CI but pass locally on my machine 🤔

skosito
skosito approved these changes May 28, 2024
View reviewed changes
Copy link
Contributor

@skosito skosito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just a question, how is chaininfo singleton initialized in case its not starting from genesis, is migration needed?

proto/zetachain/zetacore/authority/chain_info.proto Show resolved Hide resolved
kingpinXD
kingpinXD reviewed May 28, 2024
View reviewed changes
pkg/chains/chain.go Outdated Show resolved Hide resolved
@lumtis lumtis requested a review from kingpinXD May 29, 2024 12:22
@lumtis lumtis merged commit 42fe69c into develop May 29, 2024
18 of 19 checks passed
@lumtis lumtis deleted the feat/dynamic-chain-info branch May 29, 2024 14:22
@coderabbitai coderabbitai bot mentioned this pull request Nov 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kingpinXD kingpinXD kingpinXD approved these changes

@skosito skosito skosito approved these changes

@brewmaster012 brewmaster012 Awaiting requested review from brewmaster012 brewmaster012 is a code owner

@ws4charlie ws4charlie Awaiting requested review from ws4charlie ws4charlie is a code owner

Assignees
No one assigned
Labels
breaking:proto
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement ChainInfo state variable
3 participants
@lumtis @skosito @kingpinXD