-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: MsgUpdateZRC20 into MsgPauseZrc20 and MsgUnPauseZRC20 #2262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…factor-MsgUpdateZRC20 # Conflicts: # docs/cli/zetacored/zetacored_query_crosschain_in-tx-hash-to-cctx-data.md # docs/cli/zetacored/zetacored_query_crosschain_list-all-in-tx-trackers.md # docs/cli/zetacored/zetacored_query_crosschain_list-in-tx-hash-to-cctx.md # docs/cli/zetacored/zetacored_query_crosschain_list-in-tx-tracker.md # docs/cli/zetacored/zetacored_query_crosschain_list-out-tx-tracker.md # docs/cli/zetacored/zetacored_query_crosschain_show-in-tx-hash-to-cctx.md # docs/cli/zetacored/zetacored_query_crosschain_show-out-tx-tracker.md # docs/cli/zetacored/zetacored_tx_crosschain_add-to-in-tx-tracker.md # docs/cli/zetacored/zetacored_tx_crosschain_add-to-out-tx-tracker.md # docs/cli/zetacored/zetacored_tx_crosschain_inbound-voter.md # docs/cli/zetacored/zetacored_tx_crosschain_remove-from-out-tx-tracker.md # docs/cli/zetacored/zetacored_tx_fungible_pause-zrc20.md # docs/cli/zetacored/zetacored_tx_observer_enable-cctx-flags.md
kingpinXD
changed the title
refactor: Break MsgUpdateZRC20 into MsgPauseZrc20 and MsgUnPauseZRC20
refactor: MsgUpdateZRC20 into MsgPauseZrc20 and MsgUnPauseZRC20
May 24, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2262 +/- ##
===========================================
+ Coverage 68.82% 68.86% +0.04%
===========================================
Files 261 263 +2
Lines 16261 16302 +41
===========================================
+ Hits 11191 11226 +35
- Misses 4589 4594 +5
- Partials 481 482 +1
|
kingpinXD
requested review from
brewmaster012,
lumtis,
ws4charlie and
skosito
as code owners
May 24, 2024 14:00
lumtis
reviewed
May 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, small comments
Co-authored-by: Lucas Bertrand <[email protected]>
…factor-MsgUpdateZRC20
lumtis
reviewed
May 27, 2024
lumtis
approved these changes
May 28, 2024
skosito
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor MsgUpdateZRC20 into MsgPauseZrc20 and MsgUnPauseZRC20
Closes: #2244
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.
Checklist: