-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add tx priority checks to e2e tests #2184
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we didn't yet, would be great if we could (at least manually)
- Toggle off the application mempool
- Checking the test no longer pass
@lumtis thanks for review, ready for 2nd pass when this issue #2180 is not closed with this PR, i fixed it in previous and it is already merged, but lets open issue to update gosec to latest version, or rename this one from fix to update |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - minor comments
Description
Add function to monitor blocks while e2e tests are executed, and at the end of execution, n some block system transactions are not above ethermint txs, it should fail. Initially wanted to do this only for performance tests, but this seems more complete and better because one monitoring is needed per execution, not per test - open to discussion.
Monitor function is not super clean, but it is based on information in txs results.
These txs are on top because they have highest priority in mempool. If this is executed on develop before priority mempool PR was merged, it would fail, because txs were included in FIFO order.
Closes: #2182
Type of change
Test addition.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.
Checklist: