-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add import data to e2e tests #2127
Conversation
* add skip header option * use option for migration test * move bitcoin addresses tests to advanced * show cctx in logs * update version * fix verification flags error
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Import Data might not be descriptive enough, what about export/import upgrade test?
If the test is good I think we can also work on the renaming on develop
afterward
Unclear to me why do we keep the legacy genesis? Don't we export the genesis with the new binary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some minor comments, and +1 for adding more details on why legacy is needed
The import data test should ideally be run before an upgrade, so the export would be from the old binary, and the data would get imported to the current binary . This pr does nothing around export though , we still use the standard export command to export genesis which is a separate process |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is LGTM if we can create an issue to list the modification to make on develop
-> removing legacy genesis from the module source code
…o v16.0.0-import-data-testing
!!!WARNING!!! Be very careful about using Only suppress a single rule (or a specific set of rules) within a section of code, while continuing to scan for other problems. To do this, you can list the rule(s) to be suppressed within the #nosec annotation, e.g: /* #nosec G401 */ or //#nosec G201 G202 G203 Pay extra attention to the way |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/v16 #2127 +/- ##
===============================================
- Coverage 71.48% 71.37% -0.11%
===============================================
Files 252 252
Lines 14081 14102 +21
===============================================
Hits 10066 10066
- Misses 3554 3575 +21
Partials 461 461
|
Description
Adds a new test
make start-e2e-import-mainnet-test
, which does the followingCloses: #2067
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.
Checklist: