Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: docker entrypoint, start.sh #1891

Merged
merged 3 commits into from
Mar 13, 2024
Merged

fix: docker entrypoint, start.sh #1891

merged 3 commits into from
Mar 13, 2024

Conversation

gzukel
Copy link
Contributor

@gzukel gzukel commented Mar 13, 2024

Description

fix: docker entrypoint, start.sh

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

This was tested locally by building docker image and starting a network from each image.

  • Tested CCTX in localnet
  • Tested in development environment
  • Go unit tests
  • Go integration tests
  • Tested via GitHub Actions

Checklist:

  • [N/A] I have added unit tests that prove my fix feature works

@gzukel gzukel added the ci Changes to CI pipeline or github actions label Mar 13, 2024
@github-actions github-actions bot removed the ci Changes to CI pipeline or github actions label Mar 13, 2024
kingpinXD
kingpinXD reviewed Mar 13, 2024
View reviewed changes
changelog.md Outdated Show resolved Hide resolved
@gzukel gzukel merged commit 36508a9 into develop Mar 13, 2024
21 checks passed
@gzukel gzukel deleted the update-docker-automation branch March 13, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julianrubino julianrubino julianrubino approved these changes

@kingpinXD kingpinXD kingpinXD approved these changes

@brewmaster012 brewmaster012 Awaiting requested review from brewmaster012 brewmaster012 is a code owner

@kevinssgh kevinssgh Awaiting requested review from kevinssgh

@fadeev fadeev Awaiting requested review from fadeev

@lumtis lumtis Awaiting requested review from lumtis lumtis is a code owner

@ws4charlie ws4charlie Awaiting requested review from ws4charlie ws4charlie is a code owner

@skosito skosito Awaiting requested review from skosito skosito is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gzukel @kingpinXD @julianrubino