Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: e2e tests for zetaclient restricted addresses #1791

Merged
merged 19 commits into from
Mar 4, 2024

Conversation

ws4charlie
Copy link
Contributor

@ws4charlie ws4charlie commented Feb 22, 2024

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

Closes: 1810

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.

  • Tested CCTX in localnet
  • Tested in development environment
  • Go unit tests
  • Go integration tests
  • Tested via GitHub Actions

Checklist:

  • I have added unit tests that prove my fix feature works

@ws4charlie ws4charlie changed the title test: e2e tests for zetaclient banned addresses test: e2e tests for zetaclient restricted addresses Feb 23, 2024
Base automatically changed from feat-zetaclient-banned-addresses to develop February 26, 2024 19:19
e2e/e2etests/e2etests.go Outdated Show resolved Hide resolved
cmd/zetae2e/local/bitcoin.go Outdated Show resolved Hide resolved
cmd/zetae2e/local/erc20.go Outdated Show resolved Hide resolved
cmd/zetae2e/local/ethereum.go Outdated Show resolved Hide resolved
cmd/zetae2e/local/utils.go Outdated Show resolved Hide resolved
cmd/zetae2e/local/zeta.go Outdated Show resolved Hide resolved
e2e/e2etests/e2etests.go Outdated Show resolved Hide resolved
e2e/e2etests/e2etests.go Outdated Show resolved Hide resolved
Copy link
Contributor

@skosito skosito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just one minor comment

e2e/e2etests/test_erc20_deposit.go Show resolved Hide resolved
Copy link

github-actions bot commented Mar 1, 2024

!!!WARNING!!!
nosec detected in the following files: e2e/e2etests/e2etests.go

Be very careful about using #nosec in code. It can be a quick way to suppress security warnings and move forward with development, it should be employed with caution. Suppressing warnings with #nosec can hide potentially serious vulnerabilities. Only use #nosec when you're absolutely certain that the security issue is either a false positive or has been mitigated in another way.

Only suppress a single rule (or a specific set of rules) within a section of code, while continuing to scan for other problems. To do this, you can list the rule(s) to be suppressed within the #nosec annotation, e.g: /* #nosec G401 */ or //#nosec G201 G202 G203
Broad #nosec annotations should be avoided, as they can hide other vulnerabilities. The CI will block you from merging this PR until you remove #nosec annotations that do not target specific rules.

Pay extra attention to the way #nosec is being used in the files listed above.

@github-actions github-actions bot added the nosec label Mar 1, 2024
@akimov99900
Copy link

cmd/zetae2e/local/ethereum.go

@ws4charlie ws4charlie merged commit fcbb639 into develop Mar 4, 2024
20 checks passed
@ws4charlie ws4charlie deleted the feat-zetaclient-banned-addresses-e2e-tests branch March 4, 2024 19:18
@akimov99900
Copy link

fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add e2e tests for feature of 'zetaclient restricted address'
4 participants