Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Formatte l'heure avec unité de temps 00h00m00s #5261

Merged
merged 4 commits into from
Feb 2, 2019
Merged

Formatte l'heure avec unité de temps 00h00m00s #5261

merged 4 commits into from
Feb 2, 2019

Conversation

A-312
Copy link
Contributor

@A-312 A-312 commented Feb 1, 2019

Fix #5175

@coveralls
Copy link

Coverage Status

Coverage remained the same at ?% when pulling fa81309 on A-312:unitetemps into 5f2b30e on zestedesavoir:dev.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at ?% when pulling fa81309 on A-312:unitetemps into 5f2b30e on zestedesavoir:dev.

@coveralls
Copy link

coveralls commented Feb 1, 2019 •
edited
Loading

Coverage Status

Coverage remained the same at ?% when pulling 19e7678 on A-312:unitetemps into 5f2b30e on zestedesavoir:dev.

A-312 added 2 commits February 1, 2019 16:08
@A-312
Update seconds_to_duration.py
297987e
@A-312
lint
9be1bdb 
./zds/utils/templatetags/seconds_to_duration.py:7:1: E302 expected 2 blank lines, found 1
./zds/utils/templatetags/seconds_to_duration.py:8:10: Q000 Remove bad quotes
./zds/utils/templatetags/seconds_to_duration.py:9:7: Q000 Remove bad quotes
./zds/utils/templatetags/seconds_to_duration.py:10:7: Q000 Remove bad quotes
./zds/utils/templatetags/seconds_to_duration.py:10:21: Q000 Remove bad quotes
./zds/utils/templatetags/seconds_to_duration.py:14:1: E302 expected 2 blank lines, found 1
./zds/utils/templatetags/seconds_to_duration.py:24:32: Q000 Remove bad quotes
@Situphen Situphen added C-Front Concerne l'interface du site S-Évolution Ajoute de nouvelles fonctionnalités labels Feb 1, 2019
@artragis
Copy link
Member

artragis commented Feb 2, 2019

@Situphen tu peux mettre sur la béta stp qu'on puisse vraiment tester tous les cas?

@Situphen
Copy link
Member

Situphen commented Feb 2, 2019

C'est fait :)

@artragis
Copy link
Member

artragis commented Feb 2, 2019

Merci

@artragis
Copy link
Member

artragis commented Feb 2, 2019

Merci @Situphen

@A-312 tu peux enlever les heures du format stp? car la donnée en elle même ne dépasse que rarement la demie heure.

@A-312
Copy link
Contributor Author

A-312 commented Feb 2, 2019

Vous me demandez de faire des trucs en aveugle pour un langage que je connais peu :')

@artragis Voila normalement c'est bon comme ça :)

@artragis artragis merged commit dc99188 into zestedesavoir:dev Feb 2, 2019
@A-312
Copy link
Contributor Author

A-312 commented Feb 3, 2019

C'est passé ? Travis disait qu'il y avait un bug :(

@artragis
Copy link
Member

artragis commented Feb 3, 2019

en effet, j'ai été trop vite, tu as oublié un : dans ta condition. Tu peux rouvrir une PR stp?

@A-312 A-312 mentioned this pull request Feb 3, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
C-Front Concerne l'interface du site S-Évolution Ajoute de nouvelles fonctionnalités
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@A-312 @coveralls @artragis @Situphen