Do not expand all UI files as Jinja2 templates #132
Comments
mgeisler
added a commit
to mgeisler/zpm
that referenced
this issue
Jun 20, 2014
When deploying a zapp, we now only treat UI file ending in .tmpl as Jinja2 templates. Other files are uploaded verbatim. Testing with more than one UI file showed that we implictly depended on the order of iteration over the set returned by _find_ui_uploads. Sets are unordered, so the tests would fail. We now return a list instead to get deterministic output.
mgeisler
added a commit
to mgeisler/zpm
that referenced
this issue
Jun 20, 2014
When deploying a zapp, we now only treat UI file ending in .tmpl as Jinja2 templates. Other files are uploaded verbatim. Testing with more than one UI file showed that we implictly depended on the order of iteration over the set returned by _find_ui_uploads. Sets are unordered, so the tests would fail. We now return a list instead to get deterministic output.
pkit
added a commit
that referenced
this issue
Jun 20, 2014
Only process .tmpl files as Jinja2 templates (fixes #132)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When working with the video browser app, I ran into mgeisler/video-browser#6. That issue is blocked because
zpmexpands all UI files as Jinja2 templates.I suggest that we only expand UI files ending in
.tmplor similar. We would then also rename the files after expanding them. So ifzapp.yamlhasthen we would run
index.html.tmplthrough Jinja2 and store the result asindex.htmlin the zapp. We would not modifysomelib.jsat all, just include it in the zapp.The text was updated successfully, but these errors were encountered: