Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow dash to be set in bands plots. #780

Merged
merged 1 commit into from
May 30, 2024
Merged

Conversation

pfebrer
Copy link
Contributor

@pfebrer pfebrer commented May 29, 2024

This commit also makes line dash work for the matplotlib backend

One can now use the"dash" key in bands_style, as in all other line style specifications in the viz module:

sisl.get_sile("file.bands").plot(bands_style={"dash": "dot"})

newplot (73)

This commit also makes line dash work for the matplotlib backend
Copy link

codecov bot commented May 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 66.25%. Comparing base (2b299e3) to head (1c5596d).

Files Patch % Lines
src/sisl/viz/figure/matplotlib.py 0.00% 4 Missing ⚠️
src/sisl/viz/processors/bands.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #780       +/-   ##
===========================================
- Coverage   87.36%   66.25%   -21.11%     
===========================================
  Files         396      396               
  Lines       50706    50609       -97     
===========================================
- Hits        44298    33530    -10768     
- Misses       6408    17079    +10671     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zerothi zerothi merged commit 8515e2a into zerothi:main May 30, 2024
4 of 9 checks passed
@zerothi
Copy link
Owner

zerothi commented May 30, 2024

@pfebrer this one fails CI, bands.py: L132, KeyError.

@pfebrer
Copy link
Contributor Author

pfebrer commented May 30, 2024

Can you add "dash": "solid" to the default styles here?

default_styles = {"color": "black", "width": 1, "opacity": 1}

I forgot, that should solve it.

@zerothi
Copy link
Owner

zerothi commented May 30, 2024

done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants