Remove deprecated bc argument to Grid
#734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tfrederiksen
force-pushed
the
grid-bc-dep
branch
from
9ce85a6
to
9d7ac3b
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #734 +/- ##
==========================================
- Coverage 86.88% 86.86% -0.02%
==========================================
Files 406 406
Lines 51593 51617 +24
==========================================
+ Hits 44825 44836 +11
- Misses 6768 6781 +13 ☔ View full report in Codecov by Sentry. |
zerothi
approved these changes
Apr 2, 2024
|
Thanks @tfrederiksen |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code issues a deprecation warning about the (internal) use of
bctoGrid, because boundary conditions now belong toLattice. This PR fixes this.