fixed #700 by reverting 7cf88f1a5 #702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 7cf88f1 the introduction of ufunc.resolve_types was done. However, this is not a viable approach when dealing with older numpy versions. Instead we now fully rely on the return value of the ufunc. This should bypass any dtype argument handling and hopefully work with many versions of numpy. Signed-off-by: Nick Papior <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #702 +/- ##
=======================================
Coverage 86.76% 86.76%
=======================================
Files 399 399
Lines 50544 50542 -2
=======================================
- Hits 43854 43853 -1
+ Misses 6690 6689 -1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 7cf88f1 the introduction of ufunc.resolve_types was done.
However, this is not a viable approach when dealing with older numpy versions.
Instead we now fully rely on the return value of the ufunc. This should bypass any dtype argument handling and hopefully work with many versions of numpy.
This bumps numpy to 1.19.5. It should not really be a problem, since that is already quite old.
pyteston current dev version #700isort .andblack .[24.2.0] at top-leveldocs/CHANGELOG.md