Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed selector from code base #673

Merged
merged 2 commits into from
Jan 22, 2024
Merged

removed selector from code base #673

merged 2 commits into from
Jan 22, 2024

Conversation

zerothi
Copy link
Owner

@zerothi zerothi commented Jan 22, 2024

This was only used in the very early sisl
development.
It is not necessary anymore, and if others
needs it, they can extract it from the history.

  • Changes documented in CHANGELOG.md

This was only used in the very early sisl
development.
It is not necessary anymore, and if others
needs it, they can extract it from the history.

Signed-off-by: Nick Papior <[email protected]>
Signed-off-by: Nick Papior <[email protected]>
Copy link

codecov bot commented Jan 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e12093b) 87.65% compared to head (cd6e3df) 87.62%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #673      +/-   ##
==========================================
- Coverage   87.65%   87.62%   -0.04%     
==========================================
  Files         365      363       -2     
  Lines       49054    48870     -184     
==========================================
- Hits        42997    42820     -177     
+ Misses       6057     6050       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zerothi zerothi merged commit 4f73db8 into main Jan 22, 2024
8 checks passed
@zerothi zerothi deleted the remove-selector branch January 22, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant