Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure that workflows have (and transmit) the right state #667

Merged
merged 1 commit into from
Jan 4, 2024

Conversation

pfebrer
Copy link
Contributor

@pfebrer pfebrer commented Jan 4, 2024

Workflows (as opposed to simple nodes) didn't know when they were outdated or errored. This fixes it.

These fixes are part of something cool that I'm creating in the GUI:

Screenshot from 2024-01-04 13-42-43

😄

Copy link

codecov bot commented Jan 4, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (c667b7e) 87.62% compared to head (bd0ba27) 87.66%.

Files Patch % Lines
src/sisl/nodes/workflow.py 88.88% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #667      +/-   ##
==========================================
+ Coverage   87.62%   87.66%   +0.03%     
==========================================
  Files         364      364              
  Lines       48865    48913      +48     
==========================================
+ Hits        42819    42878      +59     
+ Misses       6046     6035      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zerothi zerothi merged commit e10b77b into zerothi:main Jan 4, 2024
8 checks passed
@pfebrer pfebrer deleted the workflow_state branch January 5, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants