Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added sanitize to SparseCSR and __setitem__ #652

Merged
merged 1 commit into from
Nov 9, 2023
Merged

added sanitize to SparseCSR and __setitem__ #652

merged 1 commit into from
Nov 9, 2023

Conversation

zerothi
Copy link
Owner

@zerothi zerothi commented Nov 9, 2023

This should now work more succintly by
using a good sanitizer.
It slows down the code, a tad. The test suite
is new 3:12, vs 3:10 (with one more test).
So very little.

It should fix problem #650 and allow more easier
access to the matrix elements.

This should now work more succintly by
using a good sanitizer.
It slows down the code, a tad. The test suite
is new 3:12, vs 3:10 (with one more test).
So very little.

It should fix problem #650 and allow more easier
access to the matrix elements.

Signed-off-by: Nick Papior <[email protected]>
Copy link

codecov bot commented Nov 9, 2023

Codecov Report

Attention: 19 lines in your changes are missing coverage. Please review.

Comparison is base (e01422e) 87.65% compared to head (1a3b788) 87.64%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #652      +/-   ##
==========================================
- Coverage   87.65%   87.64%   -0.01%     
==========================================
  Files         364      364              
  Lines       48520    48571      +51     
==========================================
+ Hits        42532    42572      +40     
- Misses       5988     5999      +11     
Files Coverage Δ
src/sisl/io/orca/tests/test_stdout.py 100.00% <ø> (ø)
src/sisl/sparse_geometry.py 90.30% <100.00%> (+0.01%) ⬆️
src/sisl/tests/test_sparse_geometry.py 100.00% <100.00%> (ø)
src/sisl/geometry.py 86.31% <80.00%> (-0.07%) ⬇️
src/sisl/sparse.py 93.10% <68.08%> (-1.32%) ⬇️

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zerothi zerothi merged commit 82c1e43 into main Nov 9, 2023
9 of 11 checks passed
@zerothi zerothi deleted the 650-slicing branch November 9, 2023 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sisl.physics.hamiltonian support slice operation or not?
1 participant