Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added typing hints for Lattice and LatticeChild #651

Merged
merged 1 commit into from
Nov 9, 2023
Merged

Conversation

zerothi
Copy link
Owner

@zerothi zerothi commented Nov 9, 2023

No description provided.

Copy link

codecov bot commented Nov 9, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5339e68) 87.65% compared to head (3862790) 87.65%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #651   +/-   ##
=======================================
  Coverage   87.65%   87.65%           
=======================================
  Files         364      364           
  Lines       48520    48520           
=======================================
+ Hits        42531    42532    +1     
+ Misses       5989     5988    -1     
Files Coverage Δ
src/sisl/lattice.py 93.09% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zerothi zerothi merged commit e01422e into main Nov 9, 2023
12 checks passed
@zerothi zerothi deleted the lattice-typing branch November 9, 2023 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant