Optionally avoid custom node errors. #637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Custom node errors, when shown directly, obscure the real cause of the error by only showing it in the handled exception's traceback. By default, don't raise the custom error but the original one. However, still allow the user to request the custom error to be raised, because it contains useful information like the node that errored and which inputs was using.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #637 +/- ##
==========================================
- Coverage 87.73% 87.71% -0.03%
==========================================
Files 362 362
Lines 48318 48354 +36
==========================================
+ Hits 42394 42415 +21
- Misses 5924 5939 +15
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Custom node errors (e.g.
NodeCalcError), when shown directly, obscure the real cause of the error by only showing it in the handled exception's traceback. In this PR I introduce a context key to choose whether the original error or a custom node error should be raised. By default, the original error is raised now.This should make it easier for users to understand what went wrong when running a node or workflow (plots in the viz module, for example)