Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing import in siesta_grid. #594

Merged
merged 1 commit into from
Jul 7, 2023

Conversation

nils-wittemeier
Copy link
Contributor

This import is needed when the read_grid routine receives an array of floats for the kwarg spin.

grid_reduce_indices was called in line 132 (now 133), but never imported causing a NameError.

This should fix it.

This import is needed when the `read_grid` routine receives an array of floats for the kwarg `spin`.
Copy link
Owner

@zerothi zerothi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!!

@zerothi zerothi merged commit 8f0c55a into zerothi:main Jul 7, 2023
@nils-wittemeier nils-wittemeier deleted the missing_import_siesta_grid branch July 7, 2023 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants