Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

undo change of filenames #581

Merged
merged 1 commit into from
Jun 12, 2023
Merged

undo change of filenames #581

merged 1 commit into from
Jun 12, 2023

Conversation

tfrederiksen
Copy link
Contributor

Filenames in the orca tests were (accidentally?) changed from .output to .out in da3c29b, not consistent with the sisl-files repo. This branch reverts the change.

@zerothi
Copy link
Owner

zerothi commented Jun 12, 2023

Ah, I should have caught that.
We should probably retain one of them since the code should be able to handle various codes output by testing their read_ routines.

My main motivation is that future codes will in most cases have an out file type. And in that case sisl should be able to handle them by figuring out which one is the file-type. Currently it does this by running some of the read_* methods of the sile and if they fail, so will the Sile type, removing it from the eligible siles.

I.e. here it is needed to ensure that orca siles are in fact returned. And we should strive to not use specific file extensions unless the code it-self explicitly does so. Will orca always write these .output files, or is it the user who pipes to output files?

@tfrederiksen
Copy link
Contributor Author

Will orca always write these .output files, or is it the user who pipes to output files?

It is the user who pipes to some file (and thus no standard name).

@tfrederiksen
Copy link
Contributor Author

Wouldn't be more conventional to call these files stdout?

@zerothi zerothi merged commit 597f6ea into zerothi:main Jun 12, 2023
@tfrederiksen
Copy link
Contributor Author

Note that the vasp OUTCAR is not stdout, but a fixed file it always produces. Additionally, VASP also generates stdout.

@tfrederiksen tfrederiksen deleted the orca_tests branch June 12, 2023 17:29
@zerothi
Copy link
Owner

zerothi commented Jun 12, 2023

Yes, thanks for that. From my understanding the outcar and stdout is somewhat similar, no?

@tfrederiksen
Copy link
Contributor Author

Yes, thanks for that. From my understanding the outcar and stdout is somewhat similar, no?

Not really, stdout only gives some brief info on the iterations (scf energies, optimization steps, etc).

@tfrederiksen
Copy link
Contributor Author

I have added some stdout examples in zerothi/sisl-files#7.

@zerothi
Copy link
Owner

zerothi commented Jun 13, 2023

Great, probably some cleanup in that file then ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants