Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changed SuperCell to Lattice, long overdue #550

Merged
merged 2 commits into from
Mar 15, 2023
Merged

changed SuperCell to Lattice, long overdue #550

merged 2 commits into from
Mar 15, 2023

Commits on Mar 14, 2023

  1. changed SuperCell to Lattice, long overdue 

    The ambiguity of referencing to the lattice/unit-cell
as a supercell is confusing when we are also dealing with
the description of the *number of supercells*.
Therefore we have changed all SuperCell references and sc
arguments to Lattice and lattice, respectively.

This surely comes at a cost for end-users, since this is
a major transition. I will keep backwards compatibility
with the older implementations for at least a year (perhaps
2). But they should eventually be gone to prefer the lattice.

Signed-off-by: Nick Papior <[email protected]>
    @zerothi
    zerothi committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    2edce3f View commit details
    Browse the repository at this point in the history

  2. fixed last method renames to lattice 

    Signed-off-by: Nick Papior <[email protected]>
    @zerothi
    zerothi committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    2d45aad View commit details
    Browse the repository at this point in the history