mnt: nodes context settings are no longer a regular input #547
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #538
Previously, settings that controlled the behavior of nodes where passed as function arguments, which was confusing:
Now it is instead controlled with contexts. A node's behavior is defined by its context, which is a chainmap from sisl's main context (
sisl.nodes.context.MAIN_CONTEXT
), the node class context (Node.context
), the instance context and a global temporal context.Therefore, the same behavior can be obtained in different ways, which act at different levels:
I also changed what
lazy
means. Before this PR it defined what was returned when calling a node class. If lazy, a node instance was returned and if not, the result was directly returned. Since it is now very easy to go from function to node and viceversa I thought that calling a node class should always return a node instance to avoid confusion. Nowlazy
means just whether the node should be recomputed on change of inputs, which was the oldautomatic_recalc
, now removed.