Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: functions could not overwrite node arguments #533

Merged
merged 1 commit into from
Feb 6, 2023

Conversation

pfebrer
Copy link
Contributor

@pfebrer pfebrer commented Feb 5, 2023

Closes #532.

Also added tests.


@Node.from_func
def alert_change(val: int, automatic_recalc=True):
...

Check notice

Code scanning / CodeQL

Statement has no effect

This statement has no effect.
@codecov
Copy link

codecov bot commented Feb 5, 2023

Codecov Report

Merging #533 (a02a24d) into main (24cafcb) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #533      +/-   ##
==========================================
- Coverage   86.20%   86.20%   -0.01%     
==========================================
  Files         360      360              
  Lines       45977    45978       +1     
==========================================
  Hits        39636    39636              
- Misses       6341     6342       +1     
Impacted Files Coverage Δ
sisl/geom/bilayer.py 98.66% <ø> (ø)
sisl/io/tbtrans/tbt.py 77.99% <ø> (ø)
sisl/nodes/node.py 0.00% <0.00%> (ø)
sisl/physics/distribution.py 96.55% <ø> (ø)
sisl/physics/electron.py 83.88% <ø> (ø)
sisl/physics/state.py 84.58% <ø> (ø)
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@zerothi zerothi merged commit 53ece69 into zerothi:main Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sisl.nodes (intro documentation) has duplicate parameter argument
2 participants