bug: fixed #488 with the cell order #489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #489 +/- ##
==========================================
+ Coverage 86.93% 86.94% +0.01%
==========================================
Files 346 346
Lines 44376 44403 +27
==========================================
+ Hits 38578 38606 +28
+ Misses 5798 5797 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
sisl/geom/tests/test_geom.py
Outdated
| return dot3(self.cell[0, :], cross3(self.cell[1, :], self.cell[2, :])) | ||
|
|
||
|
|
||
| def is_positive(geometry): |
There was a problem hiding this comment.
Maybe this function could be named is_righthanded to be more explicit about what is tested?
Also added tests after suggestion by @tfrederiksen.
zerothi
force-pushed
the
488-right-hand-cell
branch
from
f5eb860
to
481162d
Compare
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also added tests. @tfrederiksen
CHANGELOG