Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggestions to docs #445

Merged
merged 1 commit into from
Mar 2, 2022
Merged

Suggestions to docs #445

merged 1 commit into from
Mar 2, 2022

Conversation

tfrederiksen
Copy link
Contributor

@tfrederiksen tfrederiksen commented Mar 2, 2022 •
edited
Loading

Summary:

  • I suggest to bring the "publications" page up to a little more prominent location
  • I found two places describing how to cite sisl (reduced one of the places and inserted a link)
  • two publications added
  • fixed ase.visualization.view import problem (at least the original line didn't work for me)
  • a few typos corrected

@tfrederiksen tfrederiksen changed the title Fixes and suggestions to docs Suggestions to docs Mar 2, 2022
@tfrederiksen
Copy link
Contributor Author

By the way, I notice that the html-docs show 0.1.dev1+gff3f170 under the "home button". Why not 0.12.1+something?

zerothi
zerothi approved these changes Mar 2, 2022
View reviewed changes
Copy link
Owner

@zerothi zerothi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@zerothi zerothi merged commit 7f4772b into zerothi:main Mar 2, 2022
@zerothi
Copy link
Owner

zerothi commented Mar 2, 2022

By the way, I notice that the html-docs show 0.1.dev1+gff3f170 under the "home button". Why not 0.12.1+something?

Yeah, I haven't exactly uncovered why this is happening, because when I do sdata --version I get a sensible version! So quite annoying!

@tfrederiksen tfrederiksen deleted the docs-suggestions branch March 2, 2022 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zerothi zerothi zerothi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tfrederiksen @zerothi