mnt: changed all origo references to origin #365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tfrederiksen @sofiasanz you may have interest in this since Hubbard uses origo in some places. |
|
Seems fine to me! |
|
Actually, could you wait for #312 to be merged or remove the changes in the visualization files (I would make the changes in my branch then). It would be a nightmare to rebase my branch after these changes 😅 |
|
Yeah, I'll wait for #312. @sofiasanz @tfrederiksen I'll merge this once #312 is in. Since you haven't complained (:smile:) I guess it is ok? |
The usage of origo is a Danish word. So all is now transferred to origin. Some of the routines still enable origo, but are marked as deprecated. This will probably break some codes. Updated change-log
|
Looks good to me. Sorry for the late response. |
|
No worries! :) Thanks thomas! |
pfebrer
pushed a commit
to pfebrer/sisl
that referenced
this pull request
Sep 8, 2021
The usage of origo is a Danish word. So all is now transferred to origin. Some of the routines still enable origo, but are marked as deprecated. This will probably break some codes. Updated change-log
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The usage of origo is a Danish word. So all is now transferred
to origin. Some of the routines still enable origo, but are
marked as deprecated.
This will probably break some codes.
Updated change-log
@pfebrer please have a look at this as it touches your code... Any comments are welcome!
CHANGELOG