Poller fd bug #215
Merged
Poller fd bug #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bringing master branch to 4.2
|
Travis CI does not pass for "ZMQ_REPO=libzmq" builds, but it seems to be not related to my changes, because previous builds did not pass too (e.g. https://travis-ci.org/zeromq/zmqpp/builds/344361341). |
This reverts commit d17600d. Reason: the commit brokes poller in some cases.
|
I have reverted this commit. It was based on a wrong supposition that I can deduce the type of the socket to be reindexed from the type of the removed socket. But these are two different sockets, so the supposition is wrong. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes removing of raw fd from poller. See #207 for details.