MNT: remove Python2 only code #1916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These special methods were for Cython to support a version of the buffer protocol that was superceeded by PEP 3118 in Python 2.6 and removed from CPython in 3.0. In Cython 3.1 will be remove support for these methods and fail at build time. cython/cython#5869 closes zeromq#1915
|
Thanks! |
|
I'll add this to 25.1.2 in the morning: #1917 |
|
well, that was fast. |
|
Perfect timing, since I meant to make 25.1.2 for #1913 yesterday, but forgot. Should propagate over the next hour or two. sdist is up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These special methods were for Cython to support a version of the buffer protocol that was superceeded by PEP 3118 in Python 2.6 and removed from CPython in 3.0.
In Cython 3.1 will be remove support for these methods and fail at build time.
closes #1915
xref cython/cython#5869