Update project structure to VS2017 #649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's my understanding that these frameworks are essentially covered by `netstandard1.3`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the project to build under VS2017.
A few notes.
I've commented out support for
monoandroid60andxamarinios10because without Xamarin tools on your build machine, these won't compile. It also looks like these might be obsolete as those platforms move to supportnetstandard1.4, which we already cover. I'm not 100% sure this won't affect users though. Please review.AppVeyor configuration is now in the repo, which allows different build settings for PRs, which is quite handy.
It'd be great if others could test this out.
Closes #648 and #608