Problem: zsys_udp_new reference internal ZMQ macros #1901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solution: use external ones
bluca
reviewed
Apr 18, 2018
src/zsys.c
Outdated
| // On Windows, preventing sockets to be inherited by child processes. | ||
| #if defined ZMQ_HAVE_WINDOWS && defined HANDLE_FLAG_INHERIT | ||
| #if defined (__WINDOWS__) && defined (HANDLE_FLAG_INHERIT) |
There was a problem hiding this comment.
There's CZMQ_HAVE_WINDOWS please use that one
There was a problem hiding this comment.
Fixed in latest commit
Solution: use suggested macro for conditional compilation
bluca
reviewed
Apr 20, 2018
| @@ -981,7 +981,7 @@ zsys_udp_new (bool routable) | |||
| assert (!routable); | |||
| SOCKET udpsock; | |||
| int type = SOCK_DGRAM; | |||
| #if defined ZMQ_HAVE_SOCK_CLOEXEC | |||
| #if defined (SOCK_CLOEXEC) | |||
There was a problem hiding this comment.
@vyskocilm this will breaks some platforms - it needs to be done in cmake and autoconf like in libzmq
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution: use external ones
fixes: #1899 #1900