Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed description of 2 zhashx functions #1702

Merged
merged 2 commits into from
Jul 4, 2017
Merged

Conversation

ju-emb
Copy link
Contributor

@ju-emb ju-emb commented Jul 4, 2017

two corrections on descriptions in zhashx

one change is to correct an error in description for set_key_hasher.
bluca told me on IRC how it has to be right.

other is an addition to the description of set_key_comparator function
to eliminate possible confusion what the callback function has to return.

thanks to bluca, he pointed out the right description
making clear that callback function should return 0 on matching items just as strcmp does.
@bluca bluca merged commit 4f4dd3b into zeromq:master Jul 4, 2017
@bluca
Copy link
Member

bluca commented Jul 4, 2017

Thanks!

For your next PRs, please use the "Problem: x Solution: y" format for the commit messages, as the template suggests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants