Problem: public API/ABI changes depending on the version of libzmq #1603
Comments
bluca
added a commit
to bluca/czmq
that referenced
this issue
Jan 21, 2017
Solution: keep the public API stable regardless of the libzmq version available at build time. All the zsock_* options functions will always be available, but with both build time and runtime checks. This ensure full transparent compatibility with all versions of libzmq, and avoids ABI breakages during rebuilds. Achieved by removing the global ifdefs around the libzmq version and by avoiding redefining the same option for differen versions in sockopts.xml. Since libzmq does strict type size enforcement we can't simply cast up or down. Introduce new attributes "major_changed" and "type_new" to signal when an option type changes and to what. Fixes zeromq#1603
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In order to guarantee a stable API, I think the various zsock_ options functions should always be available. They are already ifdef'ed to no-ops if at build time the corresponding option is not available, which is the correct approach for broader compatibility, so there shouldn't be a broader ifdef checking the libzmq version.
This is mostly a reminder for myself as I don't have time right now, hopefully next week.
The text was updated successfully, but these errors were encountered: