You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Aug 21, 2024. It is now read-only.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make define switch names 'active', fix a few typo's, clarify some statements.
Refactor LED dimming (and use lower minimum).
Refactor LED table, change some characters (e.g. 't').
Refactor ds1302.c (ds_int2bcd() et al.).
Slow down alarm indicator flash frequency.
Move12h/24h handling to display (output) only (see CONF_12H, the DS1302 internally works on 24h).
The original code was already very useful. In order to understand I refactored it.
For my purposes, and to test a few theories, I changed a few little things. Enjoy!
Hi @hagen-git
thanks for the contribution!
However, before committing this to main branch, I would request that you cleanup the commit history a bit. (You may be able to accomplish this through a git interactive rebase, and resubmitting a PR.)
Please ensure related, functional changes are grouped into individual, meaningful commits, and cosmetic (whitespace/indentation/formatting) changes are grouped separately into their own related commits.
This helps ensure a clean, meaningful commit history, so future developers can understand the progression of changes over time.
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original code was already very useful. In order to understand I refactored it.
For my purposes, and to test a few theories, I changed a few little things. Enjoy!