Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#201 count total_commits #355

Merged
merged 2 commits into from
Sep 25, 2024
Merged

#201 count total_commits #355

merged 2 commits into from
Sep 25, 2024

Conversation

Suban05
Copy link
Contributor

@Suban05 Suban05 commented Sep 24, 2024

@yegor256 please merge zerocracy/fbe#103 before

Closes #201

@Suban05
Copy link
Contributor Author

Suban05 commented Sep 24, 2024

@Yegorov please review

Copy link
Contributor

@Yegorov Yegorov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Suban05 Looks good!

@Suban05
Copy link
Contributor Author

Suban05 commented Sep 24, 2024

@yegor256 please check

@yegor256 yegor256 merged commit b4c05cd into zerocracy:master Sep 25, 2024
8 checks passed
@yegor256
Copy link
Member

@Suban05 thanks!

@0crat
Copy link

0crat commented Sep 25, 2024

@Yegorov Thank you for your code review contribution! We appreciate your effort, but there's room for improvement. According to our policy, you've earned 4 base points, but we had to deduct 16 points due to the absence of comments during the review. We encourage more detailed feedback in future reviews to enhance code quality and collaboration. Despite this, we've adjusted your reward to ensure you receive the minimum 4 points. Your current balance stands at +182. Keep up the good work and remember that constructive comments are valuable for the team's success!

@0crat
Copy link

0crat commented Sep 25, 2024

@Suban05 Thank you for your contribution! We appreciate your effort. According to our policy, you've earned +4 points as a base reward. However, there were some areas for improvement: -4 points for having only 2 comments (less than 6), and -8 points for contributing 18 hits-of-code (less than 20). To ensure you receive at least the minimum reward, we've added +12 points, resulting in a total of +4 points. Please continue to focus on quality and quantity in your future contributions. Your updated balance is now +135. Keep up the good work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

total_commits into DoT
4 participants