Skip to content

Merge remote-tracking branch 'origin/router' into router #954

Merge remote-tracking branch 'origin/router' into router

Merge remote-tracking branch 'origin/router' into router #954

Triggered via push September 11, 2024 12:51
Status Failure
Total duration 1m 29s
Artifacts

lint.yml

on: push
Fit to window
Zoom out
Zoom in

Annotations

2 errors and 12 warnings
lint: contracts/callers/UniswapV2Caller.sol#L28
Line length must be no more than 99 but current length is 155
lint
Process completed with exit code 1.
lint
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions/setup-node@v1, webfactory/[email protected]. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
lint
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v2, actions/setup-node@v1, webfactory/[email protected]. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
lint: contracts/interfaces/IRouter.sol#L20
Replace ⏎····AbsoluteTokenAmount,⏎····Input,⏎····SwapDescription,⏎····AccountSignature,⏎····ProtocolFeeSignature,⏎····Fee⏎ with ·AbsoluteTokenAmount,·Input,·SwapDescription,·AccountSignature,·ProtocolFeeSignature,·Fee·
lint: contracts/interfaces/IRouter.sol#L92
Replace ·external with ⏎········external⏎·······
lint: contracts/interfaces/IUniswapV2Pair.sol#L30
Replace ⏎········uint256,⏎········uint256,⏎········address,⏎········bytes·calldata⏎···· with uint256,·uint256,·address,·bytes·calldata
lint: contracts/interfaces/IUniswapV2Pair.sol#L37
Replace ⏎········external⏎········view⏎········returns·(⏎············uint112,⏎············uint112,⏎············uint32⏎········ with ·external·view·returns·(uint112,·uint112,·uint32
lint: contracts/interfaces/IUniswapV2Router02.sol#L26
Replace ⏎········uint256,⏎········address[]·calldata,⏎········address,⏎········uint256⏎···· with uint256,·address[]·calldata,·address,·uint256
lint: contracts/interfaces/IYearnPermit.sol#L23
Replace ⏎········address,⏎········address,⏎········uint256,⏎········uint256,⏎········bytes·calldata⏎···· with address,·address,·uint256,·uint256,·bytes·calldata
lint: contracts/router/Router.sol#L33
Replace ⏎····BadAmount,⏎····BadAccount,⏎····BadAccountSignature,⏎····BadAmountType,⏎····BadFeeAmount,⏎····BadFeeBeneficiary,⏎····BadFeeShare,⏎····BadFeeSignature,⏎····ExceedingDelimiterAmount,⏎····ExceedingLimitFee,⏎····HighInputBalanceChange,⏎····InsufficientAllowance,⏎····InsufficientMsgValue,⏎····LowActualOutputAmount,⏎····NoneAmountType,⏎····NonePermitType,⏎····NoneSwapType,⏎····PassedDeadline⏎ with ·BadAmount,·BadAccount,·BadAccountSignature,·BadAmountType,·BadFeeAmount,·BadFeeBeneficiary,·BadFeeShare,·BadFeeSignature,·ExceedingDelimiterAmount,·ExceedingLimitFee,·HighInputBalanceChange,·InsufficientAllowance,·InsufficientMsgValue,·LowActualOutputAmount,·NoneAmountType,·NonePermitType,·NoneSwapType,·PassedDeadline·
lint: contracts/router/Router.sol#L54
Replace ⏎····AbsoluteTokenAmount,⏎····AccountSignature,⏎····Fee,⏎····ProtocolFeeSignature,⏎····Input,⏎····Permit,⏎····SwapDescription,⏎····TokenAmount⏎ with ·AbsoluteTokenAmount,·AccountSignature,·Fee,·ProtocolFeeSignature,·Input,·Permit,·SwapDescription,·TokenAmount·
lint: contracts/router/Router.sol#L105
Replace ·payable·override with ⏎········payable⏎········override⏎·······
lint: contracts/router/Router.sol#L408
Replace TokenAmount·calldata·tokenAmount,·address·account) with ⏎········TokenAmount·calldata·tokenAmount,⏎········address·account