fix: [audit] ZNS-12 Missing input validation #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## development #65 +/- ##
============================================
Coverage 99.79% 99.79%
============================================
Files 11 11
Lines 477 480 +3
Branches 116 119 +3
============================================
+ Hits 476 479 +3
Misses 1 1 |
JamesEarle
reviewed
Oct 30, 2023
| governorAddresses: [ ethers.constants.AddressZero ], | ||
| adminAddresses: [ ethers.constants.AddressZero ], | ||
| }) | ||
| ).to.be.revertedWith("ZNSAccessController: Can't grant role to zero address"); |
There was a problem hiding this comment.
Consider adding the new errors to the "errors" file and reference them as constants like we have been doing for all the others
JamesEarle
reviewed
Oct 30, 2023
| const newFeePerc = BigNumber.from(10001); | ||
| await expect( | ||
| zns.curvePricer.connect(user).setFeePercentage(domainHash, newFeePerc) | ||
| ).to.be.revertedWith("ZNSCurvePricer: feePercentage cannot be greater than PERCENTAGE_BASIS"); |
There was a problem hiding this comment.
Same as other comment regarding storing errors as constants for referencing
JamesEarle
approved these changes
Oct 30, 2023
fix: [audit] ZNS-12 Missing input validation
🚨 Vulnerabilities Summary
For more details view the full report in OpenZeppelin Code |
|
🎉 This PR is included in version 0.6.4 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.