Merge branch 'development' into fix/audit-zns-6

contracts/access/AAccessControlled.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: MIT
-pragma solidity ^0.8.18;
+pragma solidity 0.8.18;
 
 import { IZNSAccessController } from "./IZNSAccessController.sol";
 

contracts/access/IZNSAccessController.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: MIT
-pragma solidity ^0.8.18;
+pragma solidity 0.8.18;
 
 import { IAccessControl } from "@openzeppelin/contracts/access/IAccessControl.sol";
 

contracts/access/ZNSAccessController.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: MIT
-pragma solidity ^0.8.18;
+pragma solidity 0.8.18;
 
 import { AccessControl } from "@openzeppelin/contracts/access/AccessControl.sol";
 import { IZNSAccessController } from "./IZNSAccessController.sol";

contracts/access/ZNSRoles.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: MIT
-pragma solidity ^0.8.18;
+pragma solidity 0.8.18;
 
 
 /**

contracts/oz-proxies/ERC1967ProxyAcc.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: MIT
-pragma solidity ^0.8.18;
+pragma solidity 0.8.18;
 
 // solhint-disable-next-line no-global-import
 import "@openzeppelin/contracts/proxy/ERC1967/ERC1967Proxy.sol";

contracts/oz-proxies/TransparentUpgradeableProxyAcc.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: MIT
-pragma solidity ^0.8.18;
+pragma solidity 0.8.18;
 
 // solhint-disable-next-line no-global-import
 import "@openzeppelin/contracts/proxy/transparent/TransparentUpgradeableProxy.sol";

contracts/price/IZNSCurvePricer.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: MIT
-pragma solidity ^0.8.18;
+pragma solidity 0.8.18;
 
 import { ICurvePriceConfig } from "../types/ICurvePriceConfig.sol";
 import { IZNSPricer } from "../types/IZNSPricer.sol";

contracts/price/IZNSFixedPricer.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: MIT
-pragma solidity ^0.8.18;
+pragma solidity 0.8.18;
 
 import { IZNSPricer } from "../types/IZNSPricer.sol";
 

contracts/price/ZNSCurvePricer.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: MIT
-pragma solidity ^0.8.18;
+pragma solidity 0.8.18;
 
 import { UUPSUpgradeable } from "@openzeppelin/contracts-upgradeable/proxy/utils/UUPSUpgradeable.sol";
 import { IZNSCurvePricer } from "./IZNSCurvePricer.sol";
@@ -299,8 +299,7 @@ contract ZNSCurvePricer is AAccessControlled, ARegistryWired, UUPSUpgradeable, I
         if (length <= config.baseLength) return config.maxPrice;
         if (length > config.maxLength) return config.minPrice;
 
-        return
-        (config.baseLength * config.maxPrice / length)
+        return (config.baseLength * config.maxPrice / length)
         / config.precisionMultiplier * config.precisionMultiplier;
     }
 
@@ -312,7 +311,7 @@ contract ZNSCurvePricer is AAccessControlled, ARegistryWired, UUPSUpgradeable, I
      * which can occur if some of the config values are not properly chosen and set.
      */
     function _validateConfig(bytes32 domainHash) internal view {
-        uint256 prevToMinPrice = _getPrice(domainHash, priceConfigs[domainHash].maxLength - 1);
+        uint256 prevToMinPrice = _getPrice(domainHash, priceConfigs[domainHash].maxLength);
         require(
             priceConfigs[domainHash].minPrice <= prevToMinPrice,
             "ZNSCurvePricer: incorrect value set causes the price spike at maxLength."

contracts/price/ZNSFixedPricer.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: MIT
-pragma solidity ^0.8.18;
+pragma solidity 0.8.18;
 
 import { AAccessControlled } from "../access/AAccessControlled.sol";
 import { ARegistryWired } from "../registry/ARegistryWired.sol";

contracts/registrar/IZNSRootRegistrar.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: MIT
-pragma solidity ^0.8.18;
+pragma solidity 0.8.18;
 
 import { IDistributionConfig } from "../types/IDistributionConfig.sol";
 import { IERC20 } from "@openzeppelin/contracts/token/ERC20/IERC20.sol";

contracts/registrar/IZNSSubRegistrar.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: MIT
-pragma solidity ^0.8.18;
+pragma solidity 0.8.18;
 
 import { IDistributionConfig } from "../types/IDistributionConfig.sol";
 import { PaymentConfig } from "../treasury/IZNSTreasury.sol";

contracts/registrar/ZNSRootRegistrar.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: MIT
-pragma solidity ^0.8.18;
+pragma solidity 0.8.18;
 
 import { IZNSRootRegistrar, CoreRegisterArgs } from "./IZNSRootRegistrar.sol";
 import { IZNSTreasury } from "../treasury/IZNSTreasury.sol";

contracts/registrar/ZNSSubRegistrar.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: MIT
-pragma solidity ^0.8.18;
+pragma solidity 0.8.18;
 
 import { IZNSPricer } from "../types/IZNSPricer.sol";
 import { IZNSRootRegistrar, CoreRegisterArgs } from "./IZNSRootRegistrar.sol";

contracts/registry/ARegistryWired.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: MIT
-pragma solidity ^0.8.18;
+pragma solidity 0.8.18;
 
 import { IZNSRegistry } from "./IZNSRegistry.sol";
 

contracts/registry/ZNSRegistry.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: MIT
-pragma solidity ^0.8.18;
+pragma solidity 0.8.18;
 
 import { IZNSRegistry } from "./IZNSRegistry.sol";
 import { AAccessControlled } from "../access/AAccessControlled.sol";

contracts/resolver/IZNSAddressResolver.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: MIT
-pragma solidity ^0.8.18;
+pragma solidity 0.8.18;
 
 
 interface IZNSAddressResolver {

contracts/resolver/ZNSAddressResolver.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: MIT
-pragma solidity ^0.8.18;
+pragma solidity 0.8.18;
 
 import { ERC165 } from "@openzeppelin/contracts/utils/introspection/ERC165.sol";
 import { UUPSUpgradeable } from "@openzeppelin/contracts-upgradeable/proxy/utils/UUPSUpgradeable.sol";

contracts/token/IZNSDomainToken.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: MIT
-pragma solidity ^0.8.18;
+pragma solidity 0.8.18;
 
 import { IERC721Upgradeable } from "@openzeppelin/contracts-upgradeable/token/ERC721/IERC721Upgradeable.sol";
 import { IERC2981Upgradeable } from "@openzeppelin/contracts-upgradeable/interfaces/IERC2981Upgradeable.sol";

contracts/token/ZNSDomainToken.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: MIT
-pragma solidity ^0.8.18;
+pragma solidity 0.8.18;
 
 import { ERC721Upgradeable } from "@openzeppelin/contracts-upgradeable/token/ERC721/ERC721Upgradeable.sol";
 import { UUPSUpgradeable } from "@openzeppelin/contracts-upgradeable/proxy/utils/UUPSUpgradeable.sol";

contracts/token/mocks/CustomDecimalTokenMock.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: MIT
-pragma solidity ^0.8.18;
+pragma solidity 0.8.18;
 
 // solhint-disable
 import "@openzeppelin/contracts/token/ERC20/ERC20.sol";

contracts/token/mocks/IZeroTokenMock.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: MIT
-pragma solidity ^0.8.18;
+pragma solidity 0.8.18;
 
 import { IERC20 } from "@openzeppelin/contracts/token/ERC20/IERC20.sol";
 

contracts/token/mocks/ZeroTokenMock.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: MIT
-pragma solidity ^0.8.18;
+pragma solidity 0.8.18;
 
 // solhint-disable
 import { ZeroToken } from "@zero-tech/ztoken/contracts/ZeroToken.sol";

contracts/treasury/IZNSTreasury.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: MIT
-pragma solidity ^0.8.18;
+pragma solidity 0.8.18;
 
 import { IERC20 } from "@openzeppelin/contracts/token/ERC20/IERC20.sol";
 

contracts/treasury/ZNSTreasury.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: MIT
-pragma solidity ^0.8.18;
+pragma solidity 0.8.18;
 
 import { IZNSTreasury } from "./IZNSTreasury.sol";
 import { AAccessControlled } from "../access/AAccessControlled.sol";

contracts/types/ICurvePriceConfig.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: MIT
-pragma solidity ^0.8.18;
+pragma solidity 0.8.18;
 
 
 /**

contracts/types/IDistributionConfig.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: MIT
-pragma solidity ^0.8.18;
+pragma solidity 0.8.18;
 
 import { IZNSPricer } from "../types/IZNSPricer.sol";
 import { IERC20 } from "@openzeppelin/contracts/token/ERC20/IERC20.sol";

contracts/types/IZNSPricer.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: MIT
-pragma solidity ^0.8.18;
+pragma solidity 0.8.18;
 
 
 /**

contracts/upgrade-test-mocks/UpgradeMock.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: MIT
-pragma solidity ^0.8.18;
+pragma solidity 0.8.18;
 
  /* solhint-disable */
 contract UpgradeMock {

contracts/upgrade-test-mocks/distribution/ZNSCurvePricerMock.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: MIT
-pragma solidity ^0.8.18;
+pragma solidity 0.8.18;
 
 import { ZNSCurvePricer } from "../../price/ZNSCurvePricer.sol";
 import { UpgradeMock } from "../UpgradeMock.sol";

contracts/upgrade-test-mocks/distribution/ZNSFixedPricerMock.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: MIT
-pragma solidity ^0.8.18;
+pragma solidity 0.8.18;
 
 import { ZNSFixedPricer } from "../../price/ZNSFixedPricer.sol";
 import { UpgradeMock } from "../UpgradeMock.sol";

contracts/upgrade-test-mocks/distribution/ZNSRootRegistrarMock.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: MIT
-pragma solidity ^0.8.18;
+pragma solidity 0.8.18;
 
 import { ZNSRootRegistrar } from "../../registrar/ZNSRootRegistrar.sol";
 import { UpgradeMock } from "../UpgradeMock.sol";

contracts/upgrade-test-mocks/distribution/ZNSSubRegistrarMock.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: MIT
-pragma solidity ^0.8.18;
+pragma solidity 0.8.18;
 
 // solhint-disable
 import { ZNSSubRegistrar } from "../../registrar/ZNSSubRegistrar.sol";

contracts/upgrade-test-mocks/distribution/ZNSTreasuryMock.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: MIT
-pragma solidity ^0.8.18;
+pragma solidity 0.8.18;
 
 import { ZNSTreasury } from "../../treasury/ZNSTreasury.sol";
 import { UpgradeMock } from "../UpgradeMock.sol";

contracts/upgrade-test-mocks/registry/ZNSRegistryMock.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: MIT
-pragma solidity ^0.8.18;
+pragma solidity 0.8.18;
 
 import { ZNSRegistry } from "../../registry/ZNSRegistry.sol";
 import { UpgradeMock } from "../UpgradeMock.sol";

contracts/upgrade-test-mocks/resolver/ZNSAddressResolverMock.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: MIT
-pragma solidity ^0.8.18;
+pragma solidity 0.8.18;
 
 import { ZNSAddressResolver } from "../../resolver/ZNSAddressResolver.sol";
 import { UpgradeMock } from "../UpgradeMock.sol";

contracts/upgrade-test-mocks/token/ZNSDomainTokenMock.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: MIT
-pragma solidity ^0.8.18;
+pragma solidity 0.8.18;
 
 import { ZNSDomainToken } from "../../token/ZNSDomainToken.sol";
 import { UpgradeMock } from "../UpgradeMock.sol";

contracts/utils/StringUtils.sol

@@ -1,7 +1,7 @@
 // SPDX-License-Identifier: MIT
 // Source:
 // https://github.com/ensdomains/ens-contracts/blob/master/contracts/ethregistrar/StringUtils.sol
-pragma solidity ^0.8.18;
+pragma solidity 0.8.18;
 
 
 library StringUtils {

docs/roles.md

@@ -0,0 +1,42 @@
+# zNS Access Roles and Their Privileges
+
+## `GOVERNOR_ROLE` privileges:
+- The UUPS function `upgradeToAndCall()` allows governors to update the implementation used and invoke a call in upgradeable
+contracts. 
+- The UUPS function `upgradeTo()` allows governors to update the implementation used in upgradeable contracts. 
+- The governors can grant `GOVERNOR_ROLE` to addresses. 
+- The governors can grant `ADMIN_ROLE` to addresses. 
+- The governors can grant any role to any address through the function `ZNSAccessController.setRoleAdmin()` .
+
+## `ADMIN_ROLE` privileges:
+- The function `setRegistry()` allows admins to update the registry address for contracts inheriting `ARegistryWired`:
+  - `ZNSCurvePricer` 
+  - `ZNSRootRegistrar` 
+  - `ZNSSubRegistrar` 
+  - `ZNSAddressResolver` 
+  - `ZNSDomainToken` 
+  - `ZNSTreasury`
+- The function `ZNSRootRegister.setRootPricer()` allows admins to update the pricer contract used to determine pricing for root
+domains. 
+- The function `ZNSRootRegister.setTreasury()` allows admins to update the `ZNSTreasury` contract used to store protocol fees
+and staked funds. 
+- The function `ZNSRootRegister.setDomainToken()` allows admins to update the domain token contract used to validate domain
+ownership. 
+- The function `ZNSRootRegister.setSubRegistrar()` allows admins to update the subdomain registrar contract. 
+- The function `ZNSRootRegister.setAddressResolver()` allows admins to update the root domain resolver. 
+- The admins can grant `REGISTRAR_ROLE` to addresses.
+
+## `REGISTRAR_ROLE` privileges:
+- The function `ZNSRootRegister.coreRegister()` allows registrars to register domains. 
+- The function `ZNSRegistry.createDomainRecord()` allows registrars to register domain records which track ownership and address
+resolver. 
+- The function `ZNSDomainToken.register()` allows registrars to mint tokens which are used to validate domain ownership. 
+- The function `ZNSDomainToken.revoke()` allows registrars to burn tokens to revoke domain ownership. 
+- The function `ZNSTreasury.stakeForDomain()` allows registrars to process registration fee to beneficiaries and stake domain funds
+in the treasury. The staked funds are returned to the domain owner when the domain is revoked. 
+- The function `ZNSTreasury.unstakeForDomain()` allows registrars to unstake domain registration funds in the treasury during the
+domain revocation process. 
+- The function `ZNSTreasury.processDirectPayment()` allows registrars to process registration fees to beneficiaries directly.
+>The `REGISTRAR_ROLE` is reserved for contracts ZNSRootRegistrar and ZNSSubRegistrar only.
+
+>`EXECUTOR_ROLE` does not have any privileges. This role may be used for future implementations and additions.