Upgrade react-docgen-typescript to 2.x #50
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change description
react-docgen-typescript 1.20.5 has a bug styleguidist/react-docgen-typescript#356 that causes us not to be able to generate React snippets for our Typescript components using the Zeplin CLI.
That issue was resolved last year in styleguidist/react-docgen-typescript#360, which is in release 2.0.0.
This PR upgrades the dependency to 2.x to include that fix. Upgrading Typescript was a requirement to upgrade to this version.
As a work-around, I was able to lock the package resolution in our package by setting a resolution in
package.json
, but I'd prefer not to.Type of change
Related issues
None — I fixed this issue instead of reporting it.
Checklists
Development
Security
Code review